third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp - Issue 2287433002: Make Dictionary::toV8Impl return v8::Undefined()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 2287433002: Make Dictionary::toV8Impl return v8::Undefined() (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

index 8d19e85ab705a831330f96ef4645ecac437a863c..d44ed6feb3bf9e0a0a0994540771363f1e16354d 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

@@ -94,7 +94,7 @@ v8::Local<v8::Value> TestDictionaryDerivedImplementedAs::toV8Impl(v8::Local<v8::

{

v8::Local<v8::Object> v8Object = v8::Object::New(isolate);

if (!toV8TestDictionaryDerivedImplementedAs(*this, v8Object, creationContext, isolate))

- return v8::Local<v8::Value>();

+ return v8::Undefined(isolate);

return v8Object;

}