Create MouseWheelEvent directly instead of through MouseEvent.

Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests

Committed: https://crrev.com/1c49eca93debc59e787f27c1731911e754587cdd
Cr-Commit-Position: refs/heads/master@{#415397}

[riajiang, 2016-08-29 15:55:34]

riajiang@chromium.org changed reviewers:
+ sadrul@chromium.org, varkha@chromium.org

[riajiang, 2016-08-29 15:55:35]

varkha@, could you take a look at ash/wm?

sadrul@, could you take a look at ui/events?

Thanks!

[sadrul, 2016-08-29 16:02:37]

lgtm with nits

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc#newcode525
ui/events/event.cc:525: DCHECK(type != ET_MOUSEWHEEL);
DCHECK_NE

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc#newcode690
ui/events/event.cc:690: SetType(ui::ET_MOUSEWHEEL);
Add a comment here why we are doing this.

[riajiang, 2016-08-29 16:17:54]

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc#newcode525
ui/events/event.cc:525: DCHECK(type != ET_MOUSEWHEEL);
On 2016/08/29 16:02:36, sadrul wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/2287403002/diff/1/ui/events/event.cc#newcode690
ui/events/event.cc:690: SetType(ui::ET_MOUSEWHEEL);
On 2016/08/29 16:02:36, sadrul wrote:
> Add a comment here why we are doing this.

Done.

[varkha, 2016-08-29 19:01:39]

ash/wm lgtm.

[riajiang, 2016-08-29 19:38:51]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2016-08-29 19:38:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2287403002/#ps20001
(title: "DCHECK_NE and comment")

[commit-bot: I haz the power, 2016-08-29 20:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2016-08-30 03:57:55]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-08-30 03:58:04]

The CQ bit was unchecked by varkha@chromium.org

[riajiang, 2016-08-30 15:34:38]

Description was changed from

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests
==========

to

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests, events_unittests,
exo_unittests, browser_tests
==========

[riajiang, 2016-08-30 15:34:56]

Description was changed from

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests, events_unittests,
exo_unittests, browser_tests
==========

to

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
 events_unittests, exo_unittests, browser_tests
==========

[riajiang, 2016-08-30 15:35:09]

Description was changed from

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
 events_unittests, exo_unittests, browser_tests
==========

to

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests
==========

[riajiang, 2016-08-30 15:48:04]

riajiang@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[riajiang, 2016-08-30 15:48:04]

+sky@, could you take a look at ash/sticky_keys?
+tsepez@, could you take a look at mojo?
sadrul@, could you take a look at
chrome/browser/chromeos/events/event_rewriter_unittest.cc,
content/browser/renderer_host/input/synthetic_gesture_target_aura.cc and another
look at ui/events?
Thanks!

[sadrul, 2016-08-30 15:51:20]

lgtm++

[Tom Sepez, 2016-08-30 17:02:24]

lgtm

[sky, 2016-08-30 17:40:54]

LGTM

[riajiang, 2016-08-30 18:01:58]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 18:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:32:24]

Dry run: This issue passed the CQ dry run.

[riajiang, 2016-08-30 19:32:36]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2016-08-30 19:32:37]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org
Link to the patchset: https://codereview.chromium.org/2287403002/#ps40001
(title: "test")

[commit-bot: I haz the power, 2016-08-30 19:33:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:37:14]

Description was changed from

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests
==========

to

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests
==========

[commit-bot: I haz the power, 2016-08-30 19:37:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 19:39:19]

Description was changed from

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests
==========

to

==========
Create MouseWheelEvent directly instead of through MouseEvent.

BUG=641828
TEST=ash_unittests, unit_tests, blink_converters_unittests,
     events_unittests, exo_unittests, browser_tests

Committed: https://crrev.com/1c49eca93debc59e787f27c1731911e754587cdd
Cr-Commit-Position: refs/heads/master@{#415397}
==========

[commit-bot: I haz the power, 2016-08-30 19:39:20]

Patchset 3 (id:??) landed as
https://crrev.com/1c49eca93debc59e787f27c1731911e754587cdd
Cr-Commit-Position: refs/heads/master@{#415397}