chrome/browser/chromeos/events/event_rewriter_unittest.cc - Issue 2287403002: Create MouseWheelEvent directly instead of through MouseEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 2287403002: Create MouseWheelEvent directly instead of through MouseEvent. (Closed)

Patch Set: test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/immersive_fullscreen_controller_unittest.cc ('k') | content/browser/renderer_host/input/synthetic_gesture_target_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc

diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc

index 37eb1299fcc3f401ebd08b466337405b20792469..cb51678a9152d734fd6762d6dcbb40fad88b2e58 100644

--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc

+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc

@@ -2421,10 +2421,10 @@ TEST_F(EventRewriterAshTest, MouseWheelEventDispatchImpl) {

ui::DomKey::CONTROL);

PopEvents(&events);

gfx::Point location(0, 0);

- ui::MouseEvent mev(ui::ET_MOUSEWHEEL, location, location,

- ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,

- ui::EF_LEFT_MOUSE_BUTTON);

- ui::MouseWheelEvent positive(mev, 0, ui::MouseWheelEvent::kWheelDelta);

+ ui::MouseWheelEvent positive(

+ gfx::Vector2d(0, ui::MouseWheelEvent::kWheelDelta), location, location,

+ ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,

+ ui::EF_LEFT_MOUSE_BUTTON);

ui::EventDispatchDetails details = Send(&positive);

ASSERT_FALSE(details.dispatcher_destroyed);

PopEvents(&events);

@@ -2440,7 +2440,10 @@ TEST_F(EventRewriterAshTest, MouseWheelEventDispatchImpl) {

SendActivateStickyKeyPattern(ui::VKEY_CONTROL, ui::DomCode::CONTROL_LEFT,

ui::DomKey::CONTROL);

PopEvents(&events);

- ui::MouseWheelEvent negative(mev, 0, -ui::MouseWheelEvent::kWheelDelta);

+ ui::MouseWheelEvent negative(

+ gfx::Vector2d(0, -ui::MouseWheelEvent::kWheelDelta), location, location,

+ ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,

+ ui::EF_LEFT_MOUSE_BUTTON);

details = Send(&negative);

ASSERT_FALSE(details.dispatcher_destroyed);

PopEvents(&events);

@@ -2464,10 +2467,10 @@ TEST_F(EventRewriterAshTest, MouseWheelEventModifiersRewritten) {

// expect that it will be rewritten to ALT_DOWN.

ScopedVector<ui::Event> events;

gfx::Point location(0, 0);

- ui::MouseEvent mev(

- ui::ET_MOUSEWHEEL, location, location, ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON | ui::EF_CONTROL_DOWN, ui::EF_LEFT_MOUSE_BUTTON);

- ui::MouseWheelEvent positive(mev, 0, ui::MouseWheelEvent::kWheelDelta);

+ ui::MouseWheelEvent positive(

+ gfx::Vector2d(0, ui::MouseWheelEvent::kWheelDelta), location, location,

+ ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON | ui::EF_CONTROL_DOWN,

+ ui::EF_LEFT_MOUSE_BUTTON);

ui::EventDispatchDetails details = Send(&positive);

ASSERT_FALSE(details.dispatcher_destroyed);

PopEvents(&events);