core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp - Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp

Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@moar_better_constness

Patch Set: Casts, Casts, New -> Emplace. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp

diff --git a/core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp b/core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp

index fc054caf21cc58e26b3d88960ea45dfbe5fb7e29..e411b53a51e5d8ec3ab046fa4c90b287fd675628 100644

--- a/core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp

+++ b/core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp

@@ -11,7 +11,7 @@ CPDF_GraphicStates::CPDF_GraphicStates() {}

CPDF_GraphicStates::~CPDF_GraphicStates() {}

void CPDF_GraphicStates::DefaultStates() {

- m_ColorState.New()->Default();

+ m_ColorState.Emplace()->Default();

}

void CPDF_GraphicStates::CopyStates(const CPDF_GraphicStates& src) {

« no previous file with comments | « core/fpdfapi/fpdf_page/cpdf_allstates.cpp ('k') | core/fpdfapi/fpdf_page/cpdf_textobject.cpp » ('j') | no next file with comments »