core/fpdfapi/fpdf_page/cpdf_allstates.cpp - Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_allstates.cpp

Issue 2287313004: Make CPDF_TextState have a CPDF_TextStateData rather than inheriting one. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@moar_better_constness

Patch Set: Casts, Casts, New -> Emplace. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_page/cpdf_allstates.cpp

diff --git a/core/fpdfapi/fpdf_page/cpdf_allstates.cpp b/core/fpdfapi/fpdf_page/cpdf_allstates.cpp

index e4b6e328b9020fed2c1c19dca827d6df2a1c0dba..e01b379bedf8b76a18ede7186b1dcae622b22fb6 100644

--- a/core/fpdfapi/fpdf_page/cpdf_allstates.cpp

+++ b/core/fpdfapi/fpdf_page/cpdf_allstates.cpp

@@ -98,7 +98,7 @@ void CPDF_AllStates::ProcessExtGS(CPDF_Dictionary* pGS,

if (!pFont)

break;

- m_TextState.GetPrivateCopy()->m_FontSize = pFont->GetNumberAt(1);

+ m_TextState.SetFontSize(pFont->GetNumberAt(1));

m_TextState.SetFont(pParser->FindFont(pFont->GetStringAt(0)));

break;

}

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp » ('j') | no next file with comments »