Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2287303002: [turbofan] More efficient code generation for unsigned modulus. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] More efficient code generation for unsigned modulus. If we know statically that x and y are both in Unsigned32 or NaN or -0, and we have SignedSmall or Signed32 feedback for x % y, then we can take the feedback on the inputs and lower to Uint32Mod. Drive-by-fix: Refactor this logic into a separate method. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/24ef71d96b6e7f9c94af8bbc288624f9f06a34e5 Cr-Commit-Position: refs/heads/master@{#38975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -98 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +106 lines, -98 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 10:49:06 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the change to the SpeculativeNumberModulus reduction rule. Please take a look. Thanks, ...
4 years, 3 months ago (2016-08-29 10:49:37 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-29 11:02:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287303002/1
4 years, 3 months ago (2016-08-29 11:20:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 11:22:23 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 11:22:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24ef71d96b6e7f9c94af8bbc288624f9f06a34e5
Cr-Commit-Position: refs/heads/master@{#38975}

Powered by Google App Engine
This is Rietveld 408576698