Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2285213002: [turbofan] Assign appropriate types to some Date builtins. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign appropriate types to some Date builtins. Infer exact types for the various Date getter builtins, and also inline the Date.prototype.getTime() builtin, which just returns the Date value and thus doesn't need to check the cache stamp. R=epertoso@chromium.org Committed: https://crrev.com/529f4c87e26f5fdbcc73159013a40300710fa1a1 Cr-Commit-Position: refs/heads/master@{#38973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -45 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +63 lines, -45 lines 0 comments Download
M src/compiler/type-cache.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 10:29:12 UTC) #1
epertoso
lgtm
4 years, 3 months ago (2016-08-29 10:37:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285213002/1
4 years, 3 months ago (2016-08-29 10:45:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 10:53:34 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 10:54:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/529f4c87e26f5fdbcc73159013a40300710fa1a1
Cr-Commit-Position: refs/heads/master@{#38973}

Powered by Google App Engine
This is Rietveld 408576698