device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h - Issue 2287273002: Remove TODOs that are out of date.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

Issue 2287273002: Remove TODOs that are out of date. (Closed)

Patch Set: Fix a compile error on mac Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_descriptor_android.h ('k') | device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h b/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

index b2883c767b64b36e76b21207832034dfc721ab83..b5e09ce1b2583a8cee489c645002846c998c4316 100644

--- a/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

+++ b/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

@@ -67,7 +67,7 @@ class BluetoothRemoteGattCharacteristicBlueZ

const base::Closure& callback) override;

void ReadRemoteCharacteristic(const ValueCallback& callback,

const ErrorCallback& error_callback) override;

- void WriteRemoteCharacteristic(const std::vector<uint8_t>& new_value,

+ void WriteRemoteCharacteristic(const std::vector<uint8_t>& value,

const base::Closure& callback,

const ErrorCallback& error_callback) override;