Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_ 5 #ifndef DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_
6 #define DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_ 6 #define DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <map> 10 #include <map>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void StartNotifySession(const NotifySessionCallback& callback, 60 void StartNotifySession(const NotifySessionCallback& callback,
61 const ErrorCallback& error_callback) override; 61 const ErrorCallback& error_callback) override;
62 // Removes one value update session and invokes |callback| on completion. This 62 // Removes one value update session and invokes |callback| on completion. This
63 // decrements the session reference count by 1 and if the number reaches 0, 63 // decrements the session reference count by 1 and if the number reaches 0,
64 // makes a call to the subsystem to stop notifications from this 64 // makes a call to the subsystem to stop notifications from this
65 // characteristic. 65 // characteristic.
66 void StopNotifySession(device::BluetoothGattNotifySession* session, 66 void StopNotifySession(device::BluetoothGattNotifySession* session,
67 const base::Closure& callback) override; 67 const base::Closure& callback) override;
68 void ReadRemoteCharacteristic(const ValueCallback& callback, 68 void ReadRemoteCharacteristic(const ValueCallback& callback,
69 const ErrorCallback& error_callback) override; 69 const ErrorCallback& error_callback) override;
70 void WriteRemoteCharacteristic(const std::vector<uint8_t>& new_value, 70 void WriteRemoteCharacteristic(const std::vector<uint8_t>& value,
71 const base::Closure& callback, 71 const base::Closure& callback,
72 const ErrorCallback& error_callback) override; 72 const ErrorCallback& error_callback) override;
73 73
74 protected: 74 protected:
75 void SubscribeToNotifications( 75 void SubscribeToNotifications(
76 device::BluetoothRemoteGattDescriptor* ccc_descriptor, 76 device::BluetoothRemoteGattDescriptor* ccc_descriptor,
77 const base::Closure& callback, 77 const base::Closure& callback,
78 const ErrorCallback& error_callback) override; 78 const ErrorCallback& error_callback) override;
79 void UnsubscribeFromNotifications( 79 void UnsubscribeFromNotifications(
80 device::BluetoothRemoteGattDescriptor* ccc_descriptor, 80 device::BluetoothRemoteGattDescriptor* ccc_descriptor,
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 // invalidate its weak pointers before any other members are destroyed. 155 // invalidate its weak pointers before any other members are destroyed.
156 base::WeakPtrFactory<BluetoothRemoteGattCharacteristicBlueZ> 156 base::WeakPtrFactory<BluetoothRemoteGattCharacteristicBlueZ>
157 weak_ptr_factory_; 157 weak_ptr_factory_;
158 158
159 DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicBlueZ); 159 DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicBlueZ);
160 }; 160 };
161 161
162 } // namespace bluez 162 } // namespace bluez
163 163
164 #endif // DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_ 164 #endif // DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_BLUEZ_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698