Fix build failure with "enable_webrtc = false".

Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=

Committed: https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e
Cr-Commit-Position: refs/heads/master@{#415846}

[Shouqun1, 2016-08-29 12:33:20]

liushouqun@xiaomi.com changed reviewers:
+ esprehn@chromium.org, mcasas@chromium.org

[Shouqun1, 2016-08-29 12:33:21]

PTAL, thanks!

[mcasas, 2016-08-29 16:56:38]

https://codereview.chromium.org/2287263003/diff/1/content/content_renderer.gypi
File content/content_renderer.gypi (right):

https://codereview.chromium.org/2287263003/diff/1/content/content_renderer.gy...
content/content_renderer.gypi:627: 'public/renderer/media_stream_audio_sink.h',
Hmm I'm wondering why to single out just these few 
files, and not bundle all media_stream_* files under
these categories -- context: WebRTC grew up to encompass
not just the RTCPeerConnection-supporting classes,
but also all MediaStream and derivatives work (like, e.g.
the html_*_element_capturer_source).

So why not move all said files in the ..._webtrc_sources 
categories?

Also, to better understand why this is done, could you
file a bug?

Don't bother running master.tryserver.webrtc bots, they
won't work (always fail to patch).

[Shouqun1, 2016-08-30 01:11:48]

Description was changed from

==========
Fix build failure with "enable_webrtc = false".

BUG=
TEST=
==========

to

==========
Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=
==========

[Shouqun1, 2016-08-30 01:12:14]

https://codereview.chromium.org/2287263003/diff/1/content/content_renderer.gypi
File content/content_renderer.gypi (right):

https://codereview.chromium.org/2287263003/diff/1/content/content_renderer.gy...
content/content_renderer.gypi:627: 'public/renderer/media_stream_audio_sink.h',
On 2016/08/29 16:56:38, mcasas wrote:
> Hmm I'm wondering why to single out just these few 
> files, and not bundle all media_stream_* files under
> these categories -- context: WebRTC grew up to encompass
> not just the RTCPeerConnection-supporting classes,
> but also all MediaStream and derivatives work (like, e.g.
> the html_*_element_capturer_source).
> 
> So why not move all said files in the ..._webtrc_sources 
> categories?
> 
> Also, to better understand why this is done, could you
> file a bug?
> 
> Don't bother running master.tryserver.webrtc bots, they
> won't work (always fail to patch).

@mcasas, I have filed a bug to tracking this issue: http://crbug.com/642210
and I'll firstly try to move MediaStream files into webrtc category.

[Shouqun, 2016-08-30 05:58:04]

Patchset #2 (id:20001) has been deleted

[Shouqun1, 2016-08-30 06:07:30]

mcasas@: CL updated, moved all media stream files into webrtc_sources group.

[mcasas, 2016-08-30 17:01:01]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 17:01:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-08-30 17:01:26]

On 2016/08/30 06:07:30, Shouqun1 wrote:
> mcasas@: CL updated, moved all media stream files into webrtc_sources group.

lgtm if bots are happy, thanks!
(I just kicked a cq dry-run since 
that run more esoteric bots).

[commit-bot: I haz the power, 2016-08-30 18:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:17:52]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-08-30 20:09:35]

lgtm

[Shouqun1, 2016-08-31 01:02:14]

The CQ bit was checked by liushouqun@xiaomi.com

[commit-bot: I haz the power, 2016-08-31 01:02:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:10:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shouqun1, 2016-08-31 01:45:29]

The CQ bit was checked by liushouqun@xiaomi.com

[commit-bot: I haz the power, 2016-08-31 01:45:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:49:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shouqun, 2016-08-31 03:10:52]

The CQ bit was checked by shouqun@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 03:11:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shouqun, 2016-08-31 03:12:00]

The CQ bit was unchecked by shouqun@chromium.org

[Shouqun1, 2016-08-31 03:19:17]

liushouqun@xiaomi.com changed reviewers:
- shouqun@chromium.org

[Shouqun1, 2016-08-31 07:42:35]

liushouqun@xiaomi.com changed reviewers:
+ brettw@chromium.org

[Shouqun1, 2016-08-31 07:42:36]

+brettw
CL rebased according to https://codereview.chromium.org/2291223002, also has
change in content/public, PTAL

[brettw, 2016-08-31 21:28:09]

lgtm

[Shouqun1, 2016-09-01 00:46:03]

The CQ bit was checked by liushouqun@xiaomi.com

[Shouqun1, 2016-09-01 00:46:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2287263003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-01 00:46:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:59:32]

Description was changed from

==========
Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=
==========

to

==========
Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=
==========

[commit-bot: I haz the power, 2016-09-01 01:59:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-01 02:02:19]

Description was changed from

==========
Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=
==========

to

==========
Fix build failure with "enable_webrtc = false".

BUG=642210
TEST=

Committed: https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e
Cr-Commit-Position: refs/heads/master@{#415846}
==========

[commit-bot: I haz the power, 2016-09-01 02:02:21]

Patchset 3 (id:??) landed as
https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e
Cr-Commit-Position: refs/heads/master@{#415846}