Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2291223002: Remove content/renderer .gypi file. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content/renderer .gypi file. Inline sources into GN files. Committed: https://crrev.com/b566950bb856cd3fae946c9a158071700b276056 Cr-Commit-Position: refs/heads/master@{#415356}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+724 lines, -962 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +0 lines, -917 lines 0 comments Download
M content/public/renderer/BUILD.gn View 4 chunks +49 lines, -12 lines 0 comments Download
M content/renderer/BUILD.gn View 5 chunks +675 lines, -19 lines 0 comments Download
D content/renderer/renderer.gni View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
.
4 years, 3 months ago (2016-08-30 16:51:14 UTC) #1
brettw
4 years, 3 months ago (2016-08-30 16:51:22 UTC) #4
jam
lgtm
4 years, 3 months ago (2016-08-30 17:25:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291223002/20001
4 years, 3 months ago (2016-08-30 17:31:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291223002/20001
4 years, 3 months ago (2016-08-30 18:06:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 18:13:52 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:19:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b566950bb856cd3fae946c9a158071700b276056
Cr-Commit-Position: refs/heads/master@{#415356}

Powered by Google App Engine
This is Rietveld 408576698