Chromium Code Reviews Chromium Code Reviews
Issue
2287243003:
Revert of Enable whitelist generation for official builds. (Closed)
DescriptionRevert of Enable whitelist generation for official builds. (patchset #1 id:1 of https://codereview.chromium.org/2272713004/ )
Reason for revert:
This breaks using //build in downstream projects. E.g. V8 pulls //build, but not //tools and //third_party. While grit could be included non-trivially in our deps, the closure_compiler seems to have no mirror that can be deps'ed (we could create another subtreed to solve this).
Could you provide a solution that only conditionally imports things from //tools and e.g. is switched off in subprojects?
Original issue's description:
> Reland of Enable whitelist generation for official builds.
>
> Previous: https://codereview.chromium.org/2271673002/
>
> Currently, all resources are included in PAK files when Chrome is
> built locally. Only official_buildbot.sh uses a resource whitelist. This
> CL enables local builds to use resource whitelisting by setting the
> enable_resource_whitelist_generation gn flag to true, or by building an
> official build.
>
> This will allow developers to more easily monitor the changes in APK
> size for each commit they make.
>
> However, a large amount of output is generated (_pragma is used to
> create warnings to allow whitelisted resources to be listed), so for now
> the whitelist will only be generated for official builds.
>
> This change results in a ~1.5 mb difference when calculating the APK
> size with resource_sizes.py.
>
> BUG=632385
>
> Committed: https://crrev.com/fa33a5b9e9bb7a76fa02426c8a23a232205d83a1
> Cr-Commit-Position: refs/heads/master@{#414148}
TBR=agrieve@chromium.org,lambroslambrou@chromium.org,dpranke@chromium.org,estevenson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=632385
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
