Reland of Enable whitelist generation for official builds.

Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2271673002/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This
CL enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK
size for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK
size with resource_sizes.py.

BUG=632385
Committed: https://crrev.com/fa33a5b9e9bb7a76fa02426c8a23a232205d83a1
Cr-Commit-Position: refs/heads/master@{#414148}

[estevenson, 2016-08-24 16:32:41]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-08-24 17:45:36]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2016-08-24 17:45:37]

ptal Andrew, the reason the perf trybot was breaking in the previous CL was
because a target in remoting didn't contain a dependency to grit for adding the
-Wno-error=unknown-pragmas flag, I'll have to add an owner for that file as
well!

[agrieve, 2016-08-24 18:31:47]

On 2016/08/24 17:45:37, estevenson wrote:
> ptal Andrew, the reason the perf trybot was breaking in the previous CL was
> because a target in remoting didn't contain a dependency to grit for adding
the
> -Wno-error=unknown-pragmas flag, I'll have to add an owner for that file as
> well!

lgtm.

[agrieve, 2016-08-24 18:32:32]

agrieve@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[agrieve, 2016-08-24 18:32:32]

lambroslambrou@chromium.org: Please review changes in remoting

[Lambros, 2016-08-24 18:52:28]

lgtm

[estevenson, 2016-08-24 18:55:56]

estevenson@chromium.org changed reviewers:
+ dpranke@chromium.org

[estevenson, 2016-08-24 18:55:56]

ptal Dirk :).

[Dirk Pranke, 2016-08-24 19:31:42]

lgtm

[commit-bot: I haz the power, 2016-08-24 19:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:48:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[estevenson, 2016-08-24 19:51:07]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:51:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:18:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 21:22:24]

Description was changed from

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2271673002/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This
CL enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK
size for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK
size with resource_sizes.py.

BUG=632385
==========

to

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2271673002/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This
CL enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK
size for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK
size with resource_sizes.py.

BUG=632385

Committed: https://crrev.com/fa33a5b9e9bb7a76fa02426c8a23a232205d83a1
Cr-Commit-Position: refs/heads/master@{#414148}
==========

[commit-bot: I haz the power, 2016-08-24 21:22:25]

Patchset 1 (id:??) landed as
https://crrev.com/fa33a5b9e9bb7a76fa02426c8a23a232205d83a1
Cr-Commit-Position: refs/heads/master@{#414148}

[Michael Achenbach, 2016-08-29 10:25:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2287243003/ by machenbach@chromium.org.

The reason for reverting is: This breaks using //build in downstream projects.
E.g. V8 pulls //build, but not //tools and //third_party. While grit could be
included non-trivially in our deps, the closure_compiler seems to have no mirror
that can be deps'ed (we could create another subtreed to solve this).

Could you provide a solution that only conditionally imports things from //tools
and e.g. is switched off in subprojects?.

[Dirk Pranke, 2016-08-29 15:49:55]

On 2016/08/29 10:25:00, machenbach (slow) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2287243003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: This breaks using //build in downstream projects.
> E.g. V8 pulls //build, but not //tools and //third_party. While grit could be
> included non-trivially in our deps, the closure_compiler seems to have no
mirror
> that can be deps'ed (we could create another subtreed to solve this).
> 
> Could you provide a solution that only conditionally imports things from
//tools
> and e.g. is switched off in subprojects?.

Ick, you're absolutely right, and I should've thought of that. We don't want
//build to 
generally depend on //tools or //third_party at all IMO. I'll have to think
about how to
work around that for this.

[Lei Zhang, 2016-08-29 17:37:40]

On 2016/08/29 15:49:55, Dirk Pranke wrote:
> Ick, you're absolutely right, and I should've thought of that. We don't want
> //build to 
> generally depend on //tools or //third_party at all IMO. I'll have to think
> about how to
> work around that for this.

Yep, just hit the same issue trying to roll DEPS for build + buildtools in
standalone PDFium. PDFium does not use grit...