Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2287223003: Fix the output path for webui_test_resources.h. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the output path for webui_test_resources.h. Committed: https://crrev.com/e3672fca6483714dedec7f018c0ee1a62a7dac17 Cr-Commit-Position: refs/heads/master@{#415173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/data/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui_test_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
Currently it's out/gn/gen/chrome/chrome/test/...
4 years, 3 months ago (2016-08-29 21:41:13 UTC) #4
Dan Beam
On 2016/08/29 21:41:13, Lei Zhang wrote: > Currently it's out/gn/gen/chrome/chrome/test/... ah, lgtm
4 years, 3 months ago (2016-08-29 21:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287223003/1
4 years, 3 months ago (2016-08-30 04:26:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:43:09 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:45:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3672fca6483714dedec7f018c0ee1a62a7dac17
Cr-Commit-Position: refs/heads/master@{#415173}

Powered by Google App Engine
This is Rietveld 408576698