tools/gen-postmortem-metadata.py - Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gen-postmortem-metadata.py

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: restore undefined handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gen-postmortem-metadata.py

diff --git a/tools/gen-postmortem-metadata.py b/tools/gen-postmortem-metadata.py

index 1275bb5ed3505dbc8ac20f5d79593e2946756e6f..5fd39f3b8541ea806f48eac564ac6a31b8c70134 100644

--- a/tools/gen-postmortem-metadata.py

+++ b/tools/gen-postmortem-metadata.py

@@ -168,8 +168,6 @@ consts_misc = [

'value': 'ScopeInfo::kStackLocalCount' },

{ 'name': 'scopeinfo_idx_ncontextlocals',

'value': 'ScopeInfo::kContextLocalCount' },

- { 'name': 'scopeinfo_idx_ncontextglobals',

- 'value': 'ScopeInfo::kContextGlobalCount' },

{ 'name': 'scopeinfo_idx_first_vars',

'value': 'ScopeInfo::kVariablePartIndex' },

« no previous file with comments | « src/runtime/runtime-scopes.cc ('k') | no next file » | no next file with comments »