Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: src/objects.h

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: restore undefined handling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/runtime/runtime-scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 13d8c2f30371f03f8e4d11ed82c6a9611e88bfdb..c50f0c71b9d63f37e9cfff2d983e223bfee668dc 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4360,16 +4360,6 @@ class ScopeInfo : public FixedArray {
VariableMode* mode, InitializationFlag* init_flag,
MaybeAssignedFlag* maybe_assigned_flag);
- // Similar to ContextSlotIndex() but this method searches only among
- // global slots of the serialized scope info. Returns the context slot index
- // for a given slot name if the slot is present; otherwise returns a
- // value < 0. The name must be an internalized string. If the slot is present
- // and mode != NULL, sets *mode to the corresponding mode for that variable.
- static int ContextGlobalSlotIndex(Handle<ScopeInfo> scope_info,
- Handle<String> name, VariableMode* mode,
- InitializationFlag* init_flag,
- MaybeAssignedFlag* maybe_assigned_flag);
-
// Lookup the name of a certain context slot by its index.
String* ContextSlotName(int slot_index);
@@ -4413,8 +4403,7 @@ class ScopeInfo : public FixedArray {
V(Flags) \
V(ParameterCount) \
V(StackLocalCount) \
- V(ContextLocalCount) \
- V(ContextGlobalCount)
+ V(ContextLocalCount)
#define FIELD_ACCESSORS(name) \
inline void Set##name(int value); \
@@ -4441,8 +4430,8 @@ class ScopeInfo : public FixedArray {
// this scope are located on a stack at slots starting from this index.
// 3. StackLocalEntries:
// Contains the names of local variables that are allocated on the stack,
- // in increasing order of the stack slot index. First local variable has
- // a stack slot index defined in StackLocalFirstSlot (point 2 above).
+ // in increasing order of the stack slot index. First local variable has a
+ // stack slot index defined in StackLocalFirstSlot (point 2 above).
// One slot is used per stack local, so in total this part occupies
// StackLocalCount() slots in the array.
// 4. ContextLocalNameEntries:
@@ -4468,9 +4457,7 @@ class ScopeInfo : public FixedArray {
int StackLocalFirstSlotIndex();
int StackLocalEntriesIndex();
int ContextLocalNameEntriesIndex();
- int ContextGlobalNameEntriesIndex();
int ContextLocalInfoEntriesIndex();
- int ContextGlobalInfoEntriesIndex();
int ReceiverEntryIndex();
int FunctionNameEntryIndex();
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/runtime/runtime-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698