Ignore errors on SetDoNotFragment on platforms where it is not implemented.

Ignore errors on SetDoNotFragment on platforms where it is not implemented.

BUG=641709
R=ianswett@chromium.org, jri@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/8449205b62b9278cb76710b9bbbb06e7a7c07077

[Ryan Hamilton, 2016-08-27 21:55:56]

rch@chromium.org changed reviewers:
+ ianswett@chromium.org, jri@chromium.org

[Ryan Hamilton, 2016-08-27 21:55:57]

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1710: if (rv != OK && rv !=
ERR_NOT_IMPLEMENTED) {
Alternatively, we could ignore ALL errors since it's not crucial if this does
not succeed. That being said, from UMA, it's only failing on OS X so this fix is
sufficient.

[ianswett, 2016-08-28 18:37:49]

The CQ bit was checked by ianswett@chromium.org

[ianswett, 2016-08-28 18:37:50]

lgtm

I'm happy with this approach.  Thanks for the quick fix.

[commit-bot: I haz the power, 2016-08-28 18:38:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 19:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 19:45:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-28 20:06:40]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-28 20:06:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 21:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 21:12:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-28 23:26:05]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-28 23:26:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 00:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 00:51:52]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-29 01:56:35]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 01:56:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 03:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 03:05:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-29 03:11:53]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 03:12:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 04:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 04:27:53]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-29 04:31:29]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 04:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 05:54:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:54:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-29 13:50:06]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-08-29 13:50:11]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2016-08-29 13:50:13]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 13:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 14:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 14:58:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ryan Hamilton, 2016-08-29 16:24:20]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jana, 2016-08-29 16:50:21]

lgtm

[Ryan Hamilton, 2016-08-29 17:54:23]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2016-08-29 17:54:35]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 19:27:13]

mef@chromium.org changed reviewers:
+ mef@chromium.org

[mef, 2016-08-29 19:27:14]

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1711:
HistogramCreateSessionFailure(CREATION_ERROR_SETTING_NO_NOT_FRAGMENT);
nit: This should probably be CREATION_ERROR_SETTING_DO_NOT_FRAGMENT
(s/_NO_/_DO_/).

[Jana, 2016-08-29 19:38:59]

The CQ bit was unchecked by jri@chromium.org

[Ryan Hamilton, 2016-08-29 19:41:39]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-08-29 19:42:48]

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1711:
HistogramCreateSessionFailure(CREATION_ERROR_SETTING_NO_NOT_FRAGMENT);
On 2016/08/29 19:27:14, mef wrote:
> nit: This should probably be CREATION_ERROR_SETTING_DO_NOT_FRAGMENT
> (s/_NO_/_DO_/).

Good point. Will do so in a followup since this has been a bear to land)

[commit-bot: I haz the power, 2016-08-29 20:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 23:29:16]

Description was changed from

==========
Ignore errors on SetDoNotFragment on platforms where it is not implemented.

BUG=641709
==========

to

==========
Ignore errors on SetDoNotFragment on platforms where it is not implemented.

BUG=641709
R=ianswett@chromium.org, jri@chromium.org

Committed: https://crrev.com/8449205b62b9278cb76710b9bbbb06e7a7c07077
Cr-Commit-Position: refs/heads/master@{#415037}
==========

[commit-bot: I haz the power, 2016-08-29 23:29:17]

Patchset 2 (id:??) landed as
https://crrev.com/8449205b62b9278cb76710b9bbbb06e7a7c07077
Cr-Commit-Position: refs/heads/master@{#415037}

[Ryan Hamilton, 2016-08-29 23:30:29]

Description was changed from

==========
Ignore errors on SetDoNotFragment on platforms where it is not implemented.

BUG=641709
R=ianswett@chromium.org, jri@chromium.org

Committed: https://crrev.com/8449205b62b9278cb76710b9bbbb06e7a7c07077
Cr-Commit-Position: refs/heads/master@{#415037}
==========

to

==========
Ignore errors on SetDoNotFragment on platforms where it is not implemented.

BUG=641709
R=ianswett@chromium.org, jri@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/8449205b62b9278cb76710b9bbbb...
==========

[Ryan Hamilton, 2016-08-29 23:30:31]

Committed patchset #2 (id:20001) manually as
8449205b62b9278cb76710b9bbbb06e7a7c07077 (presubmit successful).

[Ryan Hamilton, 2016-08-29 23:31:16]

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2287073002/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1711:
HistogramCreateSessionFailure(CREATION_ERROR_SETTING_NO_NOT_FRAGMENT);
On 2016/08/29 19:42:48, Ryan Hamilton wrote:
> On 2016/08/29 19:27:14, mef wrote:
> > nit: This should probably be CREATION_ERROR_SETTING_DO_NOT_FRAGMENT
> > (s/_NO_/_DO_/).
> 
> Good point. Will do so in a followup since this has been a bear to land)

Ok, I gave up on the CQ and landed this manually, so I fixed this. Done.