Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: net/quic/chromium/quic_stream_factory.cc

Issue 2287073002: Ignore errors on SetDoNotFragment on platforms where it is not implemented. (Closed)
Patch Set: Fix enum name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_stream_factory.cc
diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc
index 2e7f2b67f77ed9bf075ae0616a1e758a26bcd95a..37a59dd64d54f95d1b8012f486053076412589b5 100644
--- a/net/quic/chromium/quic_stream_factory.cc
+++ b/net/quic/chromium/quic_stream_factory.cc
@@ -67,7 +67,7 @@ enum CreateSessionFailure {
CREATION_ERROR_CONNECTING_SOCKET,
CREATION_ERROR_SETTING_RECEIVE_BUFFER,
CREATION_ERROR_SETTING_SEND_BUFFER,
- CREATION_ERROR_SETTING_NO_NOT_FRAGMENT,
+ CREATION_ERROR_SETTING_DO_NOT_FRAGMENT,
CREATION_ERROR_MAX
};
@@ -1706,8 +1706,9 @@ int QuicStreamFactory::ConfigureSocket(DatagramClientSocket* socket,
}
rv = socket->SetDoNotFragment();
- if (rv != OK) {
- HistogramCreateSessionFailure(CREATION_ERROR_SETTING_NO_NOT_FRAGMENT);
+ // SetDoNotFragment is not implemented on all platforms, so ignore errors.
+ if (rv != OK && rv != ERR_NOT_IMPLEMENTED) {
+ HistogramCreateSessionFailure(CREATION_ERROR_SETTING_DO_NOT_FRAGMENT);
return rv;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698