Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2287023002: device/bluetooth: Fix = operator and copy constructor of BluetoothServiceAttributeValueBlueZ (Closed)

Created:
4 years, 3 months ago by Miao
Modified:
4 years, 3 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Fix = operator and copy constructor of BluetoothServiceAttributeValueBlueZ - Fix the return type of the copy constructor. - Add switch cases for different types in the "=" operator. Unittest cases - Add unittest cases for the constructor and operator. BUG=b:30963813 TEST=call the copy constructor and = operator to see if they work as expected Committed: https://crrev.com/4fb97275d2e50f6aa376a21bcf6fecaf44c1a00e Cr-Commit-Position: refs/heads/master@{#414939}

Patch Set 1 #

Patch Set 2 : change bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -19 lines) Patch
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc View 2 chunks +15 lines, -17 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc View 3 chunks +28 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Miao
4 years, 3 months ago (2016-08-27 07:01:15 UTC) #2
Miao
4 years, 3 months ago (2016-08-27 13:52:04 UTC) #6
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-08-27 16:19:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287023002/20001
4 years, 3 months ago (2016-08-27 16:39:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 16:42:42 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 16:45:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fb97275d2e50f6aa376a21bcf6fecaf44c1a00e
Cr-Commit-Position: refs/heads/master@{#414939}

Powered by Google App Engine
This is Rietveld 408576698