Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2284183002: device/bluetooth: Fix DBus message construction of CreateServiceRecord method (Closed)

Created:
4 years, 3 months ago by Miao
Modified:
4 years, 3 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Fix DBus message construction of CreateServiceRecord method This fixes the D-Bus crash caused by incorrect construction of the D-Bus CreateServiceRecord method call, which is provided by org.bluez.Adapter1 interface. BUG=b:29314637 TEST=call CreateServiceRecord with a BluetoothServiceRecord to see if D-Bus remains functional Committed: https://crrev.com/fd840dfc33b856329afac5784e245529772c68dd Cr-Commit-Position: refs/heads/master@{#414941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M device/bluetooth/dbus/bluetooth_adapter_client.cc View 2 chunks +13 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Miao
4 years, 3 months ago (2016-08-27 13:38:58 UTC) #2
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-08-27 16:20:20 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2287023002 Patch 20001). Please resolve the dependency and ...
4 years, 3 months ago (2016-08-27 16:39:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284183002/1
4 years, 3 months ago (2016-08-27 17:51:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 17:54:49 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 17:57:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd840dfc33b856329afac5784e245529772c68dd
Cr-Commit-Position: refs/heads/master@{#414941}

Powered by Google App Engine
This is Rietveld 408576698