Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2286953002: Update widget bounds after ScopedConfigure (Closed)

Created:
4 years, 3 months ago by oshima
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Update widget bounds after ScopedConfigure ScopedConfigure suppress the UpdateWidgetBounds which results in the inconsistent shadow because * the shadow bounds gets updated with the stale bounds in OnPostWindowStateTypeChanged * then the widget bounds is updated in the UpdateWidgetBounds in ScopedConfigure dtor BUG=b/30961411 TBR=reveman@chromium.org Review-Url: https://codereview.chromium.org/2277463004 Cr-Commit-Position: refs/heads/master@{#414065} (cherry picked from commit ab5745b24dd0536f27b2b4ad6160d474c77491e7) Committed: https://chromium.googlesource.com/chromium/src/+/6f5a24def08c9ea4ed74d4a5448416c98eeefbb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/exo/shell_surface.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 3 months ago (2016-08-26 21:04:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f5a24def08c9ea4ed74d4a5448416c98eeefbb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698