Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2277463004: Update widget bounds after ScopedConfigure (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update widget bounds after ScopedConfigure ScopedConfigure suppress the UpdateWidgetBounds which results in the inconsistent shadow because * the shadow bounds gets updated with the stale bounds in OnPostWindowStateTypeChanged * then the widget bounds is updated in the UpdateWidgetBounds in ScopedConfigure dtor BUG=b/30961411 Committed: https://crrev.com/ab5745b24dd0536f27b2b4ad6160d474c77491e7 Cr-Commit-Position: refs/heads/master@{#414065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/exo/shell_surface.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
oshima
4 years, 4 months ago (2016-08-24 13:06:59 UTC) #6
reveman
lgtm
4 years, 4 months ago (2016-08-24 13:33:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277463004/1
4 years, 4 months ago (2016-08-24 13:59:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 14:03:23 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:05:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab5745b24dd0536f27b2b4ad6160d474c77491e7
Cr-Commit-Position: refs/heads/master@{#414065}

Powered by Google App Engine
This is Rietveld 408576698