Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286923002: Convert analysis server over to use ContextBuilder (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment, fix bugs, clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -203 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 6 chunks +32 lines, -66 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 3 chunks +14 lines, -50 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 4 chunks +13 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart View 1 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test2.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +17 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 9 chunks +57 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 6 chunks +70 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-08-26 20:25:16 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2286923002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/2286923002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode1648 pkg/analysis_server/lib/src/analysis_server.dart:1648: .normalizedPackageRoots[folder.toString()]; folder.path?
4 years, 3 months ago (2016-08-26 21:09:58 UTC) #3
Brian Wilkerson
PTAL. I fixed a bug that I found after using a local build. https://codereview.chromium.org/2286923002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File ...
4 years, 3 months ago (2016-08-27 00:29:49 UTC) #4
scheglov
LGTM
4 years, 3 months ago (2016-08-27 04:18:50 UTC) #5
Brian Wilkerson
4 years, 3 months ago (2016-08-29 15:11:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6ccbef94fc525304497ca5d9429e75a6283b613c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698