pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart - Issue 2286923002: Convert analysis server over to use ContextBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart

Issue 2286923002: Convert analysis server over to use ContextBuilder (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: address comment, fix bugs, clean-up Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_diagnostic_test.dart ('k') | pkg/analysis_server/test/integration/analysis/highlights_test2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart

diff --git a/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart b/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart

index 2fee03a950cc3e3de058a933d7855c2e6bc1593f..70bd7aa26a81789f127680fa88bed2d0c08e700a 100644

--- a/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart

+++ b/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart

@@ -8,8 +8,6 @@ import 'dart:async';

import 'dart:io';

import 'package:analysis_server/plugin/protocol/protocol.dart';

-import 'package:analyzer/file_system/physical_file_system.dart';

-import 'package:analyzer/src/dart/sdk/sdk.dart';

import 'package:analyzer/src/generated/sdk.dart';

import 'package:path/path.dart' as path;

import 'package:test_reflective_loader/test_reflective_loader.dart';

@@ -75,10 +73,14 @@ class AnalysisDomainGetErrorsTest

}

@override

- Future startServer({int servicesPort, bool checked: true}) {

+ Future startServer(

+ {bool checked: true, int diagnosticPort, int servicesPort}) {

String sdkPath = createNonStandardSdk();

return server.start(

- servicesPort: servicesPort, checked: checked, sdkPath: sdkPath);

+ checked: checked,

+ diagnosticPort: diagnosticPort,

+ sdkPath: sdkPath,

+ servicesPort: servicesPort);

}

Future test_getErrors() async {