Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2286903002: Remove code related to the PreReadChromeChildInBrowser field trial. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code related to the PreReadChromeChildInBrowser field trial. This field trial has expired. BUG=557984 Committed: https://crrev.com/394ea7f30cb7dae99463c6ab67cac4e6e5b07fe1 Cr-Commit-Position: refs/heads/master@{#415683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -43 lines) Patch
M chrome/app/main_dll_loader_win.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M components/startup_metric_utils/common/pre_read_field_trial_utils_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/startup_metric_utils/common/pre_read_field_trial_utils_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
fdoray
gab@: Please review changes in components/startup_metric_utils rkaplow@: Please review changes in testing/variations jochen@: Please review ...
4 years, 3 months ago (2016-08-26 19:39:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-29 09:22:08 UTC) #3
gab
lgtm
4 years, 3 months ago (2016-08-31 16:41:21 UTC) #4
fdoray
asvitkine@: Please review changes in testing/variations/fieldtrial_testing_config_win.json
4 years, 3 months ago (2016-08-31 16:46:09 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-08-31 17:11:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286903002/1
4 years, 3 months ago (2016-08-31 17:15:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 18:18:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:20:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/394ea7f30cb7dae99463c6ab67cac4e6e5b07fe1
Cr-Commit-Position: refs/heads/master@{#415683}

Powered by Google App Engine
This is Rietveld 408576698