Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2280183002: Remove all code related to the PreRead field trial. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all code related to the PreRead field trial. This field trial has expired. BUG=557984 Committed: https://crrev.com/f888dced1e8295c076d99bbf57d62a217594b555 Cr-Commit-Position: refs/heads/master@{#415773}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : add comment #

Patch Set 5 : fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -358 lines) Patch
M chrome/BUILD.gn View 1 3 chunks +1 line, -3 lines 0 comments Download
M chrome/app/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/app/file_pre_reader_win.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/app/file_pre_reader_win.cc View 1 2 3 2 chunks +4 lines, -68 lines 0 comments Download
M chrome/app/main_dll_loader_win.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 6 chunks +10 lines, -32 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/startup_metric_utils/common/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D components/startup_metric_utils/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/startup_metric_utils/common/pre_read_field_trial_utils_win.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/startup_metric_utils/common/pre_read_field_trial_utils_win.cc View 1 chunk +0 lines, -147 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
fdoray
gab@chromium.org: Please review changes in components/startup_metric_utils jochen@chromium.org: Please review everything else
4 years, 3 months ago (2016-08-26 20:08:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-29 09:22:00 UTC) #3
gab
lgtm % question https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc File chrome/app/file_pre_reader_win.cc (left): https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc#oldcode44 chrome/app/file_pre_reader_win.cc:44: ::GetModuleHandle(L"kernel32.dll"), "PrefetchVirtualMemory")); Interesting, so the built-in ...
4 years, 3 months ago (2016-08-31 16:39:58 UTC) #4
fdoray
https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc File chrome/app/file_pre_reader_win.cc (left): https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc#oldcode44 chrome/app/file_pre_reader_win.cc:44: ::GetModuleHandle(L"kernel32.dll"), "PrefetchVirtualMemory")); On 2016/08/31 16:39:57, gab wrote: > Interesting, ...
4 years, 3 months ago (2016-08-31 19:50:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280183002/40001
4 years, 3 months ago (2016-08-31 19:54:26 UTC) #8
gab
https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc File chrome/app/file_pre_reader_win.cc (left): https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc#oldcode44 chrome/app/file_pre_reader_win.cc:44: ::GetModuleHandle(L"kernel32.dll"), "PrefetchVirtualMemory")); On 2016/08/31 19:50:52, fdoray wrote: > On ...
4 years, 3 months ago (2016-08-31 19:54:47 UTC) #9
fdoray
https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc File chrome/app/file_pre_reader_win.cc (left): https://codereview.chromium.org/2280183002/diff/1/chrome/app/file_pre_reader_win.cc#oldcode44 chrome/app/file_pre_reader_win.cc:44: ::GetModuleHandle(L"kernel32.dll"), "PrefetchVirtualMemory")); On 2016/08/31 19:54:47, gab wrote: > On ...
4 years, 3 months ago (2016-08-31 20:00:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280183002/60001
4 years, 3 months ago (2016-08-31 20:01:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/228175)
4 years, 3 months ago (2016-08-31 20:12:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280183002/80001
4 years, 3 months ago (2016-08-31 20:59:09 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-31 22:08:34 UTC) #20
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/f888dced1e8295c076d99bbf57d62a217594b555 Cr-Commit-Position: refs/heads/master@{#415773}
4 years, 3 months ago (2016-08-31 22:11:22 UTC) #22
chrisha
4 years, 3 months ago (2016-09-01 13:13:58 UTC) #24
Message was sent while issue was closed.
This broke the win-asan build, by removing the chrome_metrics_service_accessor.h
include. Fix here:

https://codereview.chromium.org/2302843002/

Powered by Google App Engine
This is Rietveld 408576698