|
|
DescriptionChange SBThreatType type where Safe Browsing Subresource Filter is triggered.
BUG=609747, 641037
Committed: https://crrev.com/069bcfc58e3505b86889b15f27e2da8539c2339d
Cr-Commit-Position: refs/heads/master@{#414886}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix tests #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
melandory@chromium.org changed reviewers: + engedy@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
LGTM % updating one test case. Thanks! https://codereview.chromium.org/2286883002/diff/1/components/subresource_filt... File components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc (right): https://codereview.chromium.org/2286883002/diff/1/components/subresource_filt... components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc:67: {false, subresource_filter::kActivationListPhishingInterstitial, According to trybots this should be true now, which actually makes sense.
Description was changed from ========== Change SBThreatType type where Safe Browsing subresource Filter is triggered. BUG=609747, 641037 ========== to ========== Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 ==========
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2286883002/diff/1/components/subresource_filt... File components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc (right): https://codereview.chromium.org/2286883002/diff/1/components/subresource_filt... components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc:67: {false, subresource_filter::kActivationListPhishingInterstitial, On 2016/08/26 20:19:08, engedy wrote: > According to trybots this should be true now, which actually makes sense. yep ;)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by melandory@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org Link to the patchset: https://codereview.chromium.org/2286883002/#ps20001 (title: "fix tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by melandory@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 ========== to ========== Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 ========== to ========== Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 Committed: https://crrev.com/069bcfc58e3505b86889b15f27e2da8539c2339d Cr-Commit-Position: refs/heads/master@{#414886} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/069bcfc58e3505b86889b15f27e2da8539c2339d Cr-Commit-Position: refs/heads/master@{#414886} |