Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2286883002: Change SBThreatType type where Safe Browsing Subresource Filter is triggered. (Closed)

Created:
4 years, 3 months ago by melandory
Modified:
4 years, 3 months ago
Reviewers:
engedy
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change SBThreatType type where Safe Browsing Subresource Filter is triggered. BUG=609747, 641037 Committed: https://crrev.com/069bcfc58e3505b86889b15f27e2da8539c2339d Cr-Commit-Position: refs/heads/master@{#414886}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M components/subresource_filter/core/browser/subresource_filter_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (16 generated)
melandory
PTAL, thanks!
4 years, 3 months ago (2016-08-26 19:47:32 UTC) #4
engedy
LGTM % updating one test case. Thanks! https://codereview.chromium.org/2286883002/diff/1/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc File components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc (right): https://codereview.chromium.org/2286883002/diff/1/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc#newcode67 components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc:67: {false, subresource_filter::kActivationListPhishingInterstitial, ...
4 years, 3 months ago (2016-08-26 20:19:08 UTC) #7
melandory
https://codereview.chromium.org/2286883002/diff/1/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc File components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc (right): https://codereview.chromium.org/2286883002/diff/1/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc#newcode67 components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc:67: {false, subresource_filter::kActivationListPhishingInterstitial, On 2016/08/26 20:19:08, engedy wrote: > According ...
4 years, 3 months ago (2016-08-26 22:07:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286883002/20001
4 years, 3 months ago (2016-08-26 22:45:40 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/269987)
4 years, 3 months ago (2016-08-26 23:56:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286883002/20001
4 years, 3 months ago (2016-08-27 02:54:54 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 10:27:50 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 10:31:15 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/069bcfc58e3505b86889b15f27e2da8539c2339d
Cr-Commit-Position: refs/heads/master@{#414886}

Powered by Google App Engine
This is Rietveld 408576698