components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc - Issue 2286883002: Change SBThreatType type where Safe Browsing Subresource Filter is triggered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2286883002: Change SBThreatType type where Safe Browsing Subresource Filter is triggered. (Closed)

Patch Set: fix tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

index 7e3fd08806d2b3b093a98296ffa60ce13eb2638d..51c16196644fcc8df560a968130a2a873e6d7530 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

@@ -96,8 +96,7 @@ void ContentSubresourceFilterDriverFactory::

safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS);

} else if (GetCurrentActivationList() ==

ActivationList::PHISHING_INTERSTITIAL) {

- proceed =

- (threat_type == safe_browsing::SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL);

+ proceed = (threat_type == safe_browsing::SB_THREAT_TYPE_URL_PHISHING);

}

if (!proceed)

return;

« no previous file with comments | « no previous file | components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc » ('j') | no next file with comments »