Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2286873002: drawBitmapRect() should not touch the CTM when mask filters are present (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

drawBitmapRect() should not touch the CTM when mask filters are present Blur sigma calculations are CTM dependent, so we cannot take the drawBitmap() fast path in the presence of mask filters. BUG=skia:5682 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286873002 Committed: https://skia.googlesource.com/skia/+/ab83da71426195dad58a85e2caff213358c8461d

Patch Set 1 #

Patch Set 2 : GM cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M gm/drawbitmaprect.cpp View 1 4 chunks +41 lines, -12 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +13 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
f(malita)
Also tweak an existing GM to cover subsetting.
4 years, 3 months ago (2016-08-26 19:18:17 UTC) #2
f(malita)
https://codereview.chromium.org/2286873002/diff/20001/src/core/SkBitmapDevice.cpp File src/core/SkBitmapDevice.cpp (right): https://codereview.chromium.org/2286873002/diff/20001/src/core/SkBitmapDevice.cpp#newcode237 src/core/SkBitmapDevice.cpp:237: if (!paint.getMaskFilter()) { Is there anything else downstream that ...
4 years, 3 months ago (2016-08-26 19:19:11 UTC) #5
reed1
lgtm
4 years, 3 months ago (2016-08-26 19:41:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286873002/20001
4 years, 3 months ago (2016-08-26 20:03:13 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:04:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ab83da71426195dad58a85e2caff213358c8461d

Powered by Google App Engine
This is Rietveld 408576698