Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2286833004: [CacheStorage] Keys only needs requests, not responses from QueryCache (Closed)

Created:
4 years, 3 months ago by jkarlin
Modified:
4 years, 3 months ago
Reviewers:
jsbell
CC:
chromium-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Keys only needs requests, not responses from QueryCache Optimizes QueryCache to only return requests if responses aren't needed. This prevents extra resources from being wasted. BUG=634428 Committed: https://crrev.com/57f4baf85a299a5b865bdcf0c2f80e14882feba9 Cr-Commit-Position: refs/heads/master@{#414841}

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M content/browser/cache_storage/cache_storage_cache.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
jkarlin
jsbell@ PTAL, thanks!
4 years, 3 months ago (2016-08-26 20:22:36 UTC) #4
jsbell
lgtm
4 years, 3 months ago (2016-08-26 21:22:22 UTC) #5
jkarlin
Thanks!
4 years, 3 months ago (2016-08-26 21:37:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286833004/20001
4 years, 3 months ago (2016-08-26 21:38:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 22:43:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:45:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57f4baf85a299a5b865bdcf0c2f80e14882feba9
Cr-Commit-Position: refs/heads/master@{#414841}

Powered by Google App Engine
This is Rietveld 408576698