Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: content/browser/cache_storage/cache_storage_cache.h

Issue 2286833004: [CacheStorage] Keys only needs requests, not responses from QueryCache (Closed)
Patch Set: Nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/cache_storage/cache_storage_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cache_storage/cache_storage_cache.h
diff --git a/content/browser/cache_storage/cache_storage_cache.h b/content/browser/cache_storage/cache_storage_cache.h
index 2703e229c07e440bd2cfb9492ce7bd8e3ef57b04..2e387dd0dbb2758018bc8a481f002a2ec1b2a4b8 100644
--- a/content/browser/cache_storage/cache_storage_cache.h
+++ b/content/browser/cache_storage/cache_storage_cache.h
@@ -160,7 +160,7 @@ class CONTENT_EXPORT CacheStorageCache {
base::WeakPtr<CacheStorageCache> AsWeakPtr();
private:
- enum class QueryCacheType { REQUESTS_AND_RESPONSES, CACHE_ENTRIES };
+ enum class QueryCacheType { REQUESTS, REQUESTS_AND_RESPONSES, CACHE_ENTRIES };
friend class base::RefCounted<CacheStorageCache>;
friend class TestCacheStorageCache;
@@ -201,7 +201,8 @@ class CONTENT_EXPORT CacheStorageCache {
// Runs |callback| with matching requests/response data. The data provided
// in the QueryCacheResults depends on the |query_type|. If |query_type| is
- // CACHE_ENTRIES then only out_entries is valid. If |query_type| is
+ // CACHE_ENTRIES then only out_entries is valid. If |query_type| is REQUESTS
+ // then only out_requests is valid. If |query_type| is
// REQUESTS_AND_RESPONSES then only out_requests, out_responses, and
// out_blob_data_handles are valid.
void QueryCache(std::unique_ptr<ServiceWorkerFetchRequest> request,
« no previous file with comments | « no previous file | content/browser/cache_storage/cache_storage_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698