[ios] Use new JS execution API in browsing data partitioning test.

[ios] Use new JS execution API in browsing data partitioning test.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=None

Committed: https://crrev.com/3c2c00cc8ae5cfd0afd8eafd8bc4d760ca9d5861
Cr-Commit-Position: refs/heads/master@{#415367}

[Eugene But (OOO till 7-30), 2016-08-26 16:53:55]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Eugene But (OOO till 7-30), 2016-08-29 18:39:48]

Jackie?

[Jackie Quinn, 2016-08-29 20:16:02]

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:79: return
web::ExecuteJavaScript(web_view, @"document.cookie");
Does this need to be cast, given that the new API returns id rather than string?

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:89:
web::ExecuteJavaScript(web_view, set_local_storage_item, &unused_error);
Did you mean to do some sort of error checking?

[Eugene But (OOO till 7-30), 2016-08-29 21:22:51]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-08-29 21:22:58]

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:79: return
web::ExecuteJavaScript(web_view, @"document.cookie");
On 2016/08/29 20:16:02, Jackie Quinn wrote:
> Does this need to be cast, given that the new API returns id rather than
string?
Good catch.

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:89:
web::ExecuteJavaScript(web_view, set_local_storage_item, &unused_error);
On 2016/08/29 20:16:02, Jackie Quinn wrote:
> Did you mean to do some sort of error checking?
There is a test which causes JS execution error, which should be ignored, so no
there is no need to do any checking.
web::ExecuteJavaScript which does not return NSError, simply DCHECKs on error
and can not be used here.

[Jackie Quinn, 2016-08-29 21:42:11]

lgtm, with one more return case.

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2286773002/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:89:
web::ExecuteJavaScript(web_view, set_local_storage_item, &unused_error);
On 2016/08/29 21:22:58, Eugene But wrote:
> On 2016/08/29 20:16:02, Jackie Quinn wrote:
> > Did you mean to do some sort of error checking?
> There is a test which causes JS execution error, which should be ignored, so
no
> there is no need to do any checking.
> web::ExecuteJavaScript which does not return NSError, simply DCHECKs on error
> and can not be used here.

Ah okay. Thanks for the explanation!

https://codereview.chromium.org/2286773002/diff/20001/ios/web/browser_state_w...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2286773002/diff/20001/ios/web/browser_state_w...
ios/web/browser_state_web_view_partition_inttest.mm:98: return
web::ExecuteJavaScript(web_view, get_local_storage_value);
This one probably needs a cast too then :-)

[Eugene But (OOO till 7-30), 2016-08-29 21:49:57]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-08-29 21:50:04]

https://codereview.chromium.org/2286773002/diff/20001/ios/web/browser_state_w...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2286773002/diff/20001/ios/web/browser_state_w...
ios/web/browser_state_web_view_partition_inttest.mm:98: return
web::ExecuteJavaScript(web_view, get_local_storage_value);
On 2016/08/29 21:42:11, Jackie Quinn wrote:
> This one probably needs a cast too then :-)
Whoops. This one actually needs to return id (since the result can be NSNull).

[commit-bot: I haz the power, 2016-08-29 21:57:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-08-30 02:42:10]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-30 02:42:13]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-30 02:42:14]

The patchset sent to the CQ was uploaded after l-g-t-m from jyquinn@chromium.org
Link to the patchset: https://codereview.chromium.org/2286773002/#ps40001
(title: "Make GetLocalStorageItem return id.")

[commit-bot: I haz the power, 2016-08-30 03:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:19]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-08-30 18:32:33]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:38:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 18:39:43]

Description was changed from

==========
[ios] Use new JS execution API in browsing data partitioning test.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=None
==========

to

==========
[ios] Use new JS execution API in browsing data partitioning test.

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=None

Committed: https://crrev.com/3c2c00cc8ae5cfd0afd8eafd8bc4d760ca9d5861
Cr-Commit-Position: refs/heads/master@{#415367}
==========

[commit-bot: I haz the power, 2016-08-30 18:39:44]

Patchset 3 (id:??) landed as
https://crrev.com/3c2c00cc8ae5cfd0afd8eafd8bc4d760ca9d5861
Cr-Commit-Position: refs/heads/master@{#415367}