[ios] Use new JS execution API in browsing data partitioning test.

ios/web/browser_state_web_view_partition_inttest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <WebKit/WebKit.h>
 
 #include <memory>
 #include <string>
 
 #import "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/ios/wait_util.h"
 #include "ios/web/public/browser_state.h"
 #import "ios/web/public/test/http_server.h"
+#import "ios/web/public/test/js_test_util.h"
 #include "ios/web/public/test/response_providers/string_response_provider.h"
 #import "ios/web/public/web_view_creation_util.h"
 #import "ios/web/test/web_int_test.h"
-#import "ios/web/web_state/ui/web_view_js_utils.h"
 #import "net/base/mac/url_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
 
 // A WKNavigationDelegate that is used to check if a WKWebView has finished
 // a navigation. Used for testing purposes.
 @interface TestNavigationDelegate : NSObject <WKNavigationDelegate>
 // YES if a navigation has finished.
 @property (nonatomic, assign) BOOL didFinishNavigation;
 @end
@@ skipping 29 matching lines @@
   }
 
   void TearDown() override {
     web::test::HttpServer& server = web::test::HttpServer::GetSharedInstance();
     server.RemoveResponseProvider(provider_);
     provider_ = nullptr;
 
     web::WebIntTest::TearDown();
   }
 
-  // Runs the given JavaScript on |web_view| and returns the result as a string.
-  NSString* EvaluateJavaScript(WKWebView* web_view,
-                               NSString* js) {
-    __block base::scoped_nsobject<NSString> result;
-    __block bool block_was_called = false;
-    web::EvaluateJavaScript(web_view, js, ^(NSString* js_result, NSError*) {
-      result.reset([js_result copy]);
-      block_was_called = true;
-    });
-    base::test::ios::WaitUntilCondition(^bool {
-      return block_was_called;
-    });
-    return [[result copy] autorelease];
-  }
-
   // Sets a persistent cookie with key, value on |web_view|.
   void SetCookie(NSString* key, NSString* value, WKWebView* web_view) {
     NSString* set_cookie = [NSString
         stringWithFormat:@"document.cookie='%@=%@;"
                          @"Expires=Tue, 05-May-9999 02:18:23 GMT; Path=/'",
                          key, value];
-    EvaluateJavaScript(web_view, set_cookie);
+    web::ExecuteJavaScript(web_view, set_cookie);
   }
 
   // Returns a csv list of all cookies from |web_view|.
   NSString* GetCookies(WKWebView* web_view) {
-    return EvaluateJavaScript(web_view, @"document.cookie");
+    return web::ExecuteJavaScript(web_view, @"document.cookie");

[Jackie Quinn, 2016/08/29 20:16:02]

Does this need to be cast, given that the new API returns id rather than string?

[Eugene But (OOO till 7-30), 2016/08/29 21:22:58]

Good catch.

   }
 
   // Sets a localstorage key, value pair on |web_view|.
   void SetLocalStorageItem(NSString* key,
                            NSString* value,
                            WKWebView* web_view) {
     NSString* set_local_storage_item = [NSString
         stringWithFormat:@"localStorage.setItem('%@', '%@')", key, value];
-    EvaluateJavaScript(web_view, set_local_storage_item);
+    NSError* unused_error = nil;
+    web::ExecuteJavaScript(web_view, set_local_storage_item, &unused_error);

[Jackie Quinn, 2016/08/29 20:16:02]

Did you mean to do some sort of error checking?

[Eugene But (OOO till 7-30), 2016/08/29 21:22:58]

There is a test which causes JS execution error, which should be ignored, so no
there is no need to do any checking.
web::ExecuteJavaScript which does not return NSError, simply DCHECKs on error
and can not be used here.

[Jackie Quinn, 2016/08/29 21:42:11]

Ah okay. Thanks for the explanation!

   }
 
   // Returns the localstorage value associated with |key| from |web_view|.
   NSString* GetLocalStorageItem(NSString* key, WKWebView* web_view) {
     NSString* get_local_storage_value =
         [NSString stringWithFormat:@"localStorage.getItem('%@');", key];
-    return EvaluateJavaScript(web_view, get_local_storage_value);
+    return web::ExecuteJavaScript(web_view, get_local_storage_value);
   }
 
   // Loads a test web page (that contains a small string) in |web_view| and
   // waits until the web view has finished the navigation.
   void LoadTestWebPage(WKWebView* web_view) {
     DCHECK(web_view);
 
     base::scoped_nsobject<TestNavigationDelegate> navigation_delegate(
         [[TestNavigationDelegate alloc] init]);
 
@@ skipping 53 matching lines @@
       web::CreateWKWebView(CGRectZero, GetBrowserState()));
   LoadTestWebPage(web_view_1);
   SetLocalStorageItem(@"someKey1", @"someValue1", web_view_1);
   EXPECT_NSEQ(@"someValue1", GetLocalStorageItem(@"someKey1", web_view_1));
 
   base::scoped_nsobject<WKWebView> web_view_2(
       web::CreateWKWebView(CGRectZero, GetOtrBrowserState()));
   LoadTestWebPage(web_view_2);
 
   // Test that LocalStorage has not leaked over to |web_view_2|.
-  EXPECT_NSEQ(@"", GetLocalStorageItem(@"someKey1", web_view_2));
+  EXPECT_NSEQ([NSNull null], GetLocalStorageItem(@"someKey1", web_view_2));
 
   SetLocalStorageItem(@"someKey2", @"someValue2", web_view_2);
   // Due to platform limitation, it's not possible to actually set localStorage
   // item on an OTR BrowserState. Therefore, it's not possible to verify that a
   // localStorage item has been correctly set.
   // Look at
   // http://stackoverflow.com/questions/14555347/html5-localstorage-error-with-safari-quota-exceeded-err-dom-exception-22-an
   // for more details.
   // Test that LocalStorage has not leaked over to |web_view_1|.
-  EXPECT_NSEQ(@"", GetLocalStorageItem(@"someKey2", web_view_1));
+  EXPECT_NSEQ([NSNull null], GetLocalStorageItem(@"someKey2", web_view_1));
 }