third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

diff --git a/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

index 87b7b2f5e88a05a8be4cae1fb6e67613110c3d06..a4550f0adb09462d0d96334b7654f1702b643f16 100644

--- a/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

+++ b/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

@@ -277,7 +277,7 @@ bool LengthPropertyFunctions::getLength(CSSPropertyID property, const ComputedSt

return true;

case CSSPropertyLineHeight:

// Percent Lengths are used to represent numbers on line-height.

- if (style.specifiedLineHeight().hasPercent())

+ if (style.specifiedLineHeight().isPercentOrCalc())

return false;

result = style.specifiedLineHeight();

return true;

@@ -414,7 +414,7 @@ bool LengthPropertyFunctions::setLength(CSSPropertyID property, ComputedStyle& s

case CSSPropertyLineHeight:

// Percent Lengths are used to represent numbers on line-height.

- if (value.hasPercent())

+ if (value.isPercentOrCalc())

return false;

style.setLineHeight(value);

return true;