third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

index e40e294ac45cb45a2d73d3c31a4086c30ef2a584..01931e7296f13c5c8a7e03c8f8c723eac288cd36 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

@@ -78,7 +78,7 @@ InterpolationValue CSSLengthInterpolationType::maybeConvertLength(const Length&

values->set(CSSPrimitiveValue::UnitTypePixels, InterpolableNumber::create(pixelsAndPercent.pixels / zoom));

values->set(CSSPrimitiveValue::UnitTypePercentage, InterpolableNumber::create(pixelsAndPercent.percent));

- return InterpolationValue(std::move(values), CSSLengthNonInterpolableValue::create(length.hasPercent()));

+ return InterpolationValue(std::move(values), CSSLengthNonInterpolableValue::create(length.isPercentOrCalc()));

}

std::unique_ptr<InterpolableList> CSSLengthInterpolationType::createNeutralInterpolableValue()