third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html - Issue 2286543002: Add Length::isPercent and use it in tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: and code changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html b/third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..6f09ac81e0bb6f048de4a687e9886bdc2e7a4363

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html

@@ -0,0 +1,15 @@

+<!doctype html>

+This passes if it doesn't crash. Tables were confused about percent heights

+and calc heights that included a percent.

+<style>

+html,body,table,tr { height: calc(100% - 1px); }

dgrogan 2016/08/26 00:27:18 I haven't dug in yet to understand why calc height

+</style>

+<script>

+if (window.testRunner)

+ testRunner.dumpAsText();

+</script>

+<table>

+ <tr>

+ <td></td>

+ </tr>

+</table>