third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html - Issue 2286543002: Add Length::isPercent and use it in tables.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/integer-overflow-crash.html

Issue 2286543002: Add Length::isPercent and use it in tables. (Closed)

Patch Set: and code changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 This passes if it doesn't crash. Tables were confused about percent heights

	3 and calc heights that included a percent.

	4 <style>

	5 html,body,table,tr { height: calc(100% - 1px); }
	dgrogan 2016/08/26 00:27:18 I haven't dug in yet to understand why calc height I haven't dug in yet to understand why calc height on just the tr is insufficient to trigger the crash.
	6 </style>

	7 <script>

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10 </script>

	11 <table>

	12 <tr>

	13 <td></td>

	14 </tr>

	15 </table>

OLD	NEW