Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286513002: Mojo C++ bindings: fix inlined union validation. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix inlined union validation. Previously the code couldn't correctly validate inlined nullable unions. BUG=None. Committed: https://crrev.com/f732ce652be63e7999e9ff0fd79b0bccdf14afa4 Cr-Commit-Position: refs/heads/master@{#414662}

Patch Set 1 #

Patch Set 2 : add a test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M mojo/public/cpp/bindings/lib/validation_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.cc View 1 chunk +5 lines, -8 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.data View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.expected View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom View 1 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Sam. Would you please take a look? Thanks!
4 years, 3 months ago (2016-08-25 23:57:59 UTC) #4
Sam McNally
lgtm
4 years, 3 months ago (2016-08-26 00:54:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286513002/20001
4 years, 3 months ago (2016-08-26 05:42:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 06:48:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 06:49:28 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f732ce652be63e7999e9ff0fd79b0bccdf14afa4
Cr-Commit-Position: refs/heads/master@{#414662}

Powered by Google App Engine
This is Rietveld 408576698