Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(933)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.data
Issue
2286513002
:
Mojo C++ bindings: fix inlined union validation. (Closed)
Patch Set: add a test case
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
mojo/public/cpp/bindings/lib/validation_util.h
mojo/public/cpp/bindings/lib/validation_util.cc
mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.data
mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.expected
mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom
mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« mojo/public/cpp/bindings/lib/validation_util.cc
('k') |
mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.expected »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
[dist4]message_header // num_bytes
2
[u4]0 // version
3
[u4]0 // interface ID
4
[u4]18 // name
5
[u4]0 // flags
6
[u4]0 // padding
7
[anchr]message_header
8
9
[dist4]method18_params // num_bytes
10
[u4]0 // version
11
[u4]0 // param0: Size 0 indicating the inlined union is null.
12
[u4]0 // param0: Tag field ignored.
13
[u8]0 // param0: Payload field ignored.
14
[anchr]method18_params
OLD
NEW
« no previous file with comments
|
« mojo/public/cpp/bindings/lib/validation_util.cc
('k') |
mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd18_good.expected »
('j') |
no next file with comments »
Issue 2286513002: Mojo C++ bindings: fix inlined union validation. (Closed)
Created 4 years, 3 months ago by yzshen1
Modified 4 years, 3 months ago
Reviewers: Sam McNally
Base URL:
Comments: 0
This is Rietveld
408576698