views: Textfield gets password reveal duration from ViewsDelegate

views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration

Committed: https://crrev.com/a34e954cec188f2cc09270ef801dd35ecd1072ac
Cr-Commit-Position: refs/heads/master@{#414811}

[xiyuan, 2016-08-25 21:24:01]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-25 21:31:02]

xiyuan@chromium.org changed reviewers:
+ sky@chromium.org

[xiyuan, 2016-08-25 21:31:02]

This CL is to add an API to toggle password echo in Textfields. I am working on
a dependent CL that uses the API to set it based on whether we are on TouchView
mode.

[commit-bot: I haz the power, 2016-08-25 22:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:11:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-08-25 23:02:51]

Please hold on the review. Let me fix the test failures first.

[xiyuan, 2016-08-25 23:24:37]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 23:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:29:42]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-08-26 05:08:14]

Okay. Tests are passing now. Ready for review. Thanks.

[xiyuan, 2016-08-26 13:10:19]

Description was changed from

==========
views: Set Textfield password reveal duration via ViewsDelegate

Add a ViewsDelegate API to set Textfield password reveal duration
to allow it to be changed pragmatically.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

to

==========
views: Set Textfield password reveal duration via ViewsDelegate

Make Textfield to get password reveal duration from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

[sky, 2016-08-26 16:11:12]

I actually prefer no setter as it avoids the problem of portions of the code
fighting over setting the value. Say one place wants 10, the other 5. Those
problems are better left up to clients. It seems like the problem you are fixing
is separate from that, so it seems you don't need the setter?

[xiyuan, 2016-08-26 17:27:29]

Description was changed from

==========
views: Set Textfield password reveal duration via ViewsDelegate

Make Textfield to get password reveal duration from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

to

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ memeber in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

[xiyuan, 2016-08-26 17:27:39]

Description was changed from

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ memeber in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

to

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

[xiyuan, 2016-08-26 17:31:30]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:32:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-26 17:33:26]

On 2016/08/26 16:11:12, sky wrote:
> I actually prefer no setter as it avoids the problem of portions of the code
> fighting over setting the value. Say one place wants 10, the other 5. Those
> problems are better left up to clients. It seems like the problem you are
fixing
> is separate from that, so it seems you don't need the setter?

Makes sense.

Removed the setter and use existing ViewsDelegate getter (rename as it is called
password reveal duration in Textfield now). TextfieldTestApi changes are not
used in this CL but used its dependent CL.

PTAL. Thanks.

[sky, 2016-08-26 19:02:53]

LGTM

https://codereview.chromium.org/2286433002/diff/40001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2286433002/diff/40001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:2028: base::TimeDelta
Textfield::GetPasswordRevealDuration() {
Make this an anonymous function and move to namespace at top of file.

[xiyuan, 2016-08-26 19:45:40]

https://codereview.chromium.org/2286433002/diff/40001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2286433002/diff/40001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:2028: base::TimeDelta
Textfield::GetPasswordRevealDuration() {
On 2016/08/26 19:02:52, sky wrote:
> Make this an anonymous function and move to namespace at top of file.

Done.

[xiyuan, 2016-08-26 19:45:47]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-08-26 19:45:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2286433002/#ps60001
(title: "move GetPasswordRevealDuration to cc and revert TextfieldTestApi
change")

[commit-bot: I haz the power, 2016-08-26 19:46:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:29:59]

Description was changed from

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

to

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

[commit-bot: I haz the power, 2016-08-26 21:30:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 21:31:49]

Description was changed from

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration
==========

to

==========
views: Textfield gets password reveal duration from ViewsDelegate

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration

Committed: https://crrev.com/a34e954cec188f2cc09270ef801dd35ecd1072ac
Cr-Commit-Position: refs/heads/master@{#414811}
==========

[commit-bot: I haz the power, 2016-08-26 21:31:50]

Patchset 4 (id:??) landed as
https://crrev.com/a34e954cec188f2cc09270ef801dd35ecd1072ac
Cr-Commit-Position: refs/heads/master@{#414811}