cros: Bind password echo with TouchView mode

cros: Bind password echo with TouchView mode

Enable password echo when entering TouchView mode and disable it
when exiting TouchView mode.

BUG=634472
TEST=PasswordEchoControllerTest.*

[xiyuan, 2016-08-26 05:31:06]

xiyuan@chromium.org changed reviewers:
+ oshima@chromium.org

[xiyuan, 2016-08-26 05:31:15]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 05:31:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 06:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 06:24:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-08-26 17:03:02]

Please hold off review. Making changes in the dependency views CL and looking at
the test failures. Will ping back when it is ready. Sorry for the noise.

[xiyuan, 2016-08-26 17:30:24]

Patchset #2 (id:20001) has been deleted

[xiyuan, 2016-08-26 17:34:38]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:35:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-26 17:37:37]

Ready to review. PTAL. Thanks.

[commit-bot: I haz the power, 2016-08-26 18:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:17:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-08-26 19:46:33]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 19:47:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-26 19:48:28]

xiyuan@chromium.org changed reviewers:
+ sky@chromium.org

[xiyuan, 2016-08-26 19:48:28]

+sky

ha, still need you to look at this dependent CL for the following:
  chrome_views_delegate.h
  chrome_views_delegate_chromeos.cc

:)

[commit-bot: I haz the power, 2016-08-26 20:00:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:00:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-08-26 20:09:28]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 20:10:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:26:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-08-26 22:48:00]

https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
File chrome/browser/ui/views/chrome_views_delegate_chromeos.cc (right):

https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
chrome/browser/ui/views/chrome_views_delegate_chromeos.cc:17: const
base::TimeDelta kTextfieldPasswordRevealDuration =
Did you consider doing this if the mouse recent pointer event (which includes
touch and mouse) is a touch event? I think it's worth asking UX about this given
it seems helpful on desktop when using a touch input device too.

[xiyuan, 2016-08-26 23:20:31]

The CL will not work for mash since it tries to get TouchView via WmShell's
maximize_mode_controller. I skipped it for mash in PS5 and added to comment to
revisit it later.

PTAL. Thanks.

https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
File chrome/browser/ui/views/chrome_views_delegate_chromeos.cc (right):

https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
chrome/browser/ui/views/chrome_views_delegate_chromeos.cc:17: const
base::TimeDelta kTextfieldPasswordRevealDuration =
On 2016/08/26 22:48:00, sky wrote:
> Did you consider doing this if the mouse recent pointer event (which includes
> touch and mouse) is a touch event? I think it's worth asking UX about this
given
> it seems helpful on desktop when using a touch input device too.

I see your point. The part that I am not sure is how confident we are to enable
this with touch events. People might not want this just because they tap on a
password field.

Will ask UX on the bug.

[xiyuan, 2016-08-26 23:20:38]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:19:36]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[oshima, 2016-10-11 21:25:49]

On 2016/08/26 23:20:31, xiyuan wrote:
> The CL will not work for mash since it tries to get TouchView via WmShell's
> maximize_mode_controller. I skipped it for mash in PS5 and added to comment to
> revisit it later.
> 
> PTAL. Thanks.
> 
>
https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
> File chrome/browser/ui/views/chrome_views_delegate_chromeos.cc (right):
> 
>
https://codereview.chromium.org/2279163002/diff/70001/chrome/browser/ui/views...
> chrome/browser/ui/views/chrome_views_delegate_chromeos.cc:17: const
> base::TimeDelta kTextfieldPasswordRevealDuration =
> On 2016/08/26 22:48:00, sky wrote:
> > Did you consider doing this if the mouse recent pointer event (which
includes
> > touch and mouse) is a touch event? I think it's worth asking UX about this
> given
> > it seems helpful on desktop when using a touch input device too.
> 
> I see your point. The part that I am not sure is how confident we are to
enable
> this with touch events. People might not want this just because they tap on a
> password field.
> 
> Will ask UX on the bug.

Alternative approach is to check if the key event is synthesized which, IIRC,
indicates it's coming from software keybaord (but sorry if I'm wrong).