Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 228643003: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttribut… (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes()). R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -114 lines) Patch
M src/elements.h View 3 chunks +2 lines, -20 lines 0 comments Download
M src/elements.cc View 20 chunks +69 lines, -94 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-08 14:29:54 UTC) #1
Toon Verwaest
lgtm
6 years, 8 months ago (2014-04-09 09:49:28 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-09 09:58:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698