Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: src/elements.h

Issue 228643003: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttribut… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 0ef45d0b2c17395c8c74e68f9a6c4555bbebb520..76b2b0ebfbbaed670c04499c74836edfdb36a5b4 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -226,11 +226,7 @@ class ElementsAccessor {
return elements_accessors_[elements_kind];
}
- // TODO(ishell): Temporary wrapper until handlified.
- inline static ElementsAccessor* ForArray(Handle<FixedArrayBase> array) {
- return ForArray(*array);
- }
- static ElementsAccessor* ForArray(FixedArrayBase* array);
+ static ElementsAccessor* ForArray(Handle<FixedArrayBase> array);
static void InitializeOncePerProcess();
static void TearDown();
@@ -238,7 +234,7 @@ class ElementsAccessor {
protected:
friend class SloppyArgumentsElementsAccessor;
- virtual uint32_t GetCapacity(FixedArrayBase* backing_store) = 0;
+ virtual uint32_t GetCapacity(Handle<FixedArrayBase> backing_store) = 0;
// Element handlers distinguish between indexes and keys when they manipulate
// elements. Indexes refer to elements in terms of their location in the
@@ -251,20 +247,6 @@ class ElementsAccessor {
virtual uint32_t GetKeyForIndex(Handle<FixedArrayBase> backing_store,
uint32_t index) = 0;
- // TODO(ishell): Non-handlified versions, used only by accessors'
- // implementations. To be removed once elements.cc is handlified.
- MUST_USE_RESULT virtual PropertyAttributes GetAttributes(
- Object* receiver,
- JSObject* holder,
- uint32_t key,
- FixedArrayBase* backing_store) = 0;
-
- MUST_USE_RESULT virtual PropertyType GetType(
- Object* receiver,
- JSObject* holder,
- uint32_t key,
- FixedArrayBase* backing_store) = 0;
-
private:
static ElementsAccessor** elements_accessors_;
const char* name_;
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698