Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286413003: DevTools: refactor DOMBreakpointsSidebarPane to use Map and Set (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: refactor DOMBreakpointsSidebarPane to use Map and Set BUG=627296 Committed: https://crrev.com/81442b85a5b0a79b7ccaf1a53f2076b02d19d651 Cr-Commit-Position: refs/heads/master@{#415118}

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 13 chunks +25 lines, -29 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
chenwilliam
PTAL. https://codereview.chromium.org/2286413003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js (right): https://codereview.chromium.org/2286413003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js#newcode373 third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:373: /** @type {!Map<string, !Array<!Object>>} */ I'm planning on ...
4 years, 3 months ago (2016-08-29 20:10:43 UTC) #2
chenwilliam
PTAL.
4 years, 3 months ago (2016-08-29 20:10:45 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2286413003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js (right): https://codereview.chromium.org/2286413003/diff/20001/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js#newcode332 third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:332: var breakpointId = this._createBreakpointId(auxData.nodeId, auxData.type); let's get rid ...
4 years, 3 months ago (2016-08-29 22:19:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286413003/20001
4 years, 3 months ago (2016-08-29 23:30:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 04:50:33 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:53:28 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/81442b85a5b0a79b7ccaf1a53f2076b02d19d651
Cr-Commit-Position: refs/heads/master@{#415118}

Powered by Google App Engine
This is Rietveld 408576698