third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html - Issue 2286413003: DevTools: refactor DOMBreakpointsSidebarPane to use Map and Set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

Issue 2286413003: DevTools: refactor DOMBreakpointsSidebarPane to use Map and Set (Closed)

Patch Set: Nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

index cdb29b6408ad38ee30e110a66b17c0b541d0b4d5..aeb999cb72ac59a487bea3c9ba1205c57d157f64 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

@@ -109,7 +109,7 @@ function test()

WebInspector.domBreakpointsSidebarPane._setBreakpoint(rootElement, pane._breakpointTypes.AttributeModified, true);

InspectorTest.addResult("Set DOM breakpoint.");

var elementId = pane._createBreakpointId(rootElement.id, pane._breakpointTypes.AttributeModified);

- var element = pane._breakpointElements[elementId];

+ var element = pane._breakpointElements.get(elementId);

element._checkboxElement.click();

InspectorTest.addResult("Uncheck DOM breakpoint.");

InspectorTest.evaluateInPagePromise("modifyAttribute('rootElement', 'data-test-breakpoint-toggle', 'foo')").then(step2);