[LayoutNG] Initial NGLayoutOpportunityIterator implementation

[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
Committed: https://crrev.com/711a3a27b412945f808224f948c0d0e0e8a7bd1d
Cr-Commit-Position: refs/heads/master@{#415417}

[eae, 2016-08-29 23:03:39]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[ikilpatrick, 2016-08-29 23:05:55]

lgtm

[eae, 2016-08-29 23:40:33]

The CQ bit was unchecked by eae@chromium.org

[eae, 2016-08-29 23:40:34]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-08-29 23:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-30 00:34:33]

The CQ bit was unchecked by eae@chromium.org

[eae, 2016-08-30 15:49:47]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:50:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-30 15:54:22]

Description was changed from

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusionss, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

[cbiesinger, 2016-08-30 15:58:01]

lgtm

https://codereview.chromium.org/2286403004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
(right):

https://codereview.chromium.org/2286403004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:51: auto
iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
Should this be NGClearFragment...?

https://codereview.chromium.org/2286403004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:53: auto
firstOppertunity = iterator.Next();
Since it's unclear what the type of this variable is, I think you should make it
NGConstraintSpace* instead of auto

Also: opportunity

[eae, 2016-08-30 16:10:15]

Thanks, good catch!

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[eae, 2016-08-30 16:10:16]

Thanks, good catch!

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eae, 2016-08-30 17:32:39]

The CQ bit was checked by eae@chromium.org

[eae, 2016-08-30 17:32:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2286403004/#ps20001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-08-30 17:33:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:43:20]

Description was changed from

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

[commit-bot: I haz the power, 2016-08-30 20:43:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 20:45:22]

Description was changed from

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Initial NGLayoutOpportunityIterator implementation

Add initial simple NGLayoutOpportunityIterator implementation. Does not
yet handle exclusions, inlines or bfcs.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619

Committed: https://crrev.com/711a3a27b412945f808224f948c0d0e0e8a7bd1d
Cr-Commit-Position: refs/heads/master@{#415417}
==========

[commit-bot: I haz the power, 2016-08-30 20:45:23]

Patchset 2 (id:??) landed as
https://crrev.com/711a3a27b412945f808224f948c0d0e0e8a7bd1d
Cr-Commit-Position: refs/heads/master@{#415417}