Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2286403003: [ash-md] Corrects a color in user manager error message (Closed)

Created:
4 years, 3 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Corrects a color in user manager error message After https://codereview.chromium.org/2283583003 the text color (dark) no longer matches the background (dark). Fix that by removing the text color override for the login manager warnings. BUG=641855 TEST=with the steps in the bug the color scheme for warnings should match the tooltips in web-ui (0.87 alpha white on 0.8 opacity black). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/292580044e75d7104f9fbf53bdd374143242ab2b Cr-Commit-Position: refs/heads/master@{#415197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/md_user_manager/user_manager.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
varkha
xiyuan@, can you please take a look? Thanks!
4 years, 3 months ago (2016-08-29 22:33:35 UTC) #4
xiyuan
lgtm
4 years, 3 months ago (2016-08-29 22:46:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286403003/1
4 years, 3 months ago (2016-08-30 02:45:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:04:55 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:08:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292580044e75d7104f9fbf53bdd374143242ab2b
Cr-Commit-Position: refs/heads/master@{#415197}

Powered by Google App Engine
This is Rietveld 408576698