Issue 2286403002: [Offline pages] Eliminating duplicate notifications, by fixing request queue store

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2286403002: [Offline pages] Eliminating duplicate notifications, by fixing request queue store (Closed)

Created:
4 years, 3 months ago by fgorski

Modified:
4 years, 3 months ago

Reviewers:
Pete Williamson

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Offline pages] Eliminating duplicate notifications, by fixing request queue store * Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG=641380 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2283813003 Cr-Commit-Position: refs/heads/master@{#414790} (cherry picked from commit 36bb3dc904af1b642b516515780ce137b4806c34) Committed: https://chromium.googlesource.com/chromium/src/+/ae2738c3da44a1a83632f0df6d127c99dfb386cb

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
	M	components/offline_pages/background/request_queue_store_sql.cc	View		2 chunks	+12 lines, -10 lines	0 comments	Download
	M	components/offline_pages/background/request_queue_store_unittest.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

fgorski

4 years, 3 months ago (2016-08-29 17:05:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ae2738c3da44a1a83632f0df6d127c99dfb386cb.