Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2283813003: [Offline pages] Eliminating duplicate notifications, by fixing request queue store (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Eliminating duplicate notifications, by fixing request queue store * Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG=641380 R=dewittj@chromium.org Committed: https://crrev.com/36bb3dc904af1b642b516515780ce137b4806c34 Cr-Commit-Position: refs/heads/master@{#414790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M components/offline_pages/background/request_queue_store_sql.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M components/offline_pages/background/request_queue_store_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fgorski
PTAL
4 years, 3 months ago (2016-08-26 19:02:23 UTC) #2
Pete Williamson
lgtm
4 years, 3 months ago (2016-08-26 19:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283813003/1
4 years, 3 months ago (2016-08-26 20:03:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 20:09:14 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:12:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36bb3dc904af1b642b516515780ce137b4806c34
Cr-Commit-Position: refs/heads/master@{#414790}

Powered by Google App Engine
This is Rietveld 408576698