Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4328)

Unified Diff: cc/surfaces/display.h

Issue 2286273003: Make cc::Display not own its BeginFrameSource (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/display.h
diff --git a/cc/surfaces/display.h b/cc/surfaces/display.h
index bf786ae15c48bf839311097c02ce2bf894b17fd4..a558184ac1182988cb660d0a53dac81169952768 100644
--- a/cc/surfaces/display.h
+++ b/cc/surfaces/display.h
@@ -57,7 +57,7 @@ class CC_SURFACES_EXPORT Display : public DisplaySchedulerClient,
Display(SharedBitmapManager* bitmap_manager,
gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
const RendererSettings& settings,
- std::unique_ptr<BeginFrameSource> begin_frame_source,
+ BeginFrameSource* begin_frame_source,
std::unique_ptr<OutputSurface> output_surface,
std::unique_ptr<DisplayScheduler> scheduler,
std::unique_ptr<TextureMailboxDeleter> texture_mailbox_deleter);
@@ -131,9 +131,9 @@ class CC_SURFACES_EXPORT Display : public DisplaySchedulerClient,
gfx::Rect external_viewport_;
bool output_is_secure_ = false;
- // The begin_frame_source_ is often known by the output_surface_ and
- // the scheduler_.
- std::unique_ptr<BeginFrameSource> begin_frame_source_;
+ // The begin_frame_source_ is often also known by the output_surface_ and the
+ // scheduler_.
+ BeginFrameSource* begin_frame_source_;
danakj 2016/08/30 01:10:56 can it be a const member maybe up with the bitmap_
std::unique_ptr<OutputSurface> output_surface_;
std::unique_ptr<DisplayScheduler> scheduler_;
std::unique_ptr<ResourceProvider> resource_provider_;

Powered by Google App Engine
This is Rietveld 408576698